The TOR network itself is safe - at least assuming the TLAs don't control at least half of the nodes, which is far from impossible. But let's assume...
The weak point comes from the browser: that's how the fuzz deanonymizes users. The only safe browser to use on TOR is the TOR browser, and that's the problem: it disables so many unsafe functionalities that it's essentially unusable on a lot of websites. So people use regular browsers over TOR, the browser leaks identifying data and that's how they get caught.
I mean, the advice I've heard for one who's threat model is "the feds are actively trying to identify me" is to have a dedicated burner computer that you do all of your illegal activities on and no other activities. Then of course on top of that avoid saving secrets onto the device and type them in manually every time (ephemeral distros like Tails are good for that)
All VPNs do is change who has your browsing data: your ISP or the VPN operator. You may or may not trust either of them not to keep records, in either case you have no way of verifying this.
ISPs definitely keep records. At least some VPNs claim that they don't, and that their networks are set up in such a way that they can't. Some organizations claim to validate the claims of the VPNs, but it's unclear if they're trustworthy.
So your choice is to use something that definitely keeps logs, or to use a company that at least says that they don't/can't.
Yes, and there's also the fact that some VPNs such as Mullvad let you be anonymous so even if Mullvad were keeping logs, if you pay privately they have no way of knowing whose logs they are (unless the content itself of your internet history reveals your identity). Meanwhile your ISP definitely knows who you are, and absolutely will collaborate with the police if asked to.
As Proton made evident, VPNs can be legally compelled to start keeping logs on specific accounts as the result of a court order. So if you're gonna do something incriminating, then I guess you should create a new account each time.
That's true but it also depends what attack vector you're trying to defeat. If someone is doing a timing attack and you're running through a VPN, it might be harder to work for them, depending on where they sit.
That's exactly the reasoning I did for choosing a VPN. I know that VPNs are falsely advertised as "anonymous black magic" but better Proton or Mullvad than my ISP which definitely sells data to advertisers