Nah, the article says he was wandering around the plane trying to steal food and chat with strangers. That’s a lot of interactions over the course of an eight-hour flight. A spy would surely keep a much lower profile than that… Or maybe that’s how he throws people off his trail!
Actually... That's just James Bond. Straight up telling people his name, purposely annoying the bad guy, because he already knows everything the first 10 seconds of looking at the villain.
So, typically an employee of an intelligence agency has a diplomatic passport and is attached to an embassy or some such. It is considered generally unacceptable (at least in some countries) to have a cover as a journalist, but other private employment is allowed. Being an intelligence officer with a cover as part of an aid agency is generally not allowed, although that does happen, and results in things like vaccine refusals and the execution of medical personnel who are trying to eliminate diseases. I’m not going into specifics, but one of the places where that happened rhymes with “Wackystan.”
Anyway, the job of the intelligence officer is to recruit spies, like an admin assistant in some government agency. They generally don’t do the physical spying themselves, but they’ll use various approaches to get foreign nationals to send them files and such.
In any case, this person just seems like a cool con man. The absolute last thing someone involved in intelligence wants to do is attract attention (most of the time - some recent Russian operations in the US have been quite blatant), and this person was just having a great time.