On harmful overuse of std::move - The Old New Thing
On harmful overuse of std::move - The Old New Thing
Initial excitement leads to overuse.
You're viewing a single thread.
I wonder if the language could be updated so these extra std::move invocations actually become harmless? return std::move is something that I see used quite a bit.
@QuadriLiteral @lysdexic We've been looking at a paper just recently in Kona, where the author proposed to not penalize "unfortunate" uses of std::move. I think this is user friendly and you might imagine what I've been voting for.
That sounds great!
I wonder if the language could be updated so these extra std::move invocations actually become harmless? return std::move is something that I see used quite a bit.
These
std::moveinvocations are harmless, as they only cast objects to their rvalue reference.The destructive bit takes place in the type they are assigned to, as it invokes either a move constructor or a move assignment operator, and calling those implies that the object you just passed to
std::movewill be invalidated after the call and should not be used subsequently.I mean harmless in a way that using std::move on the return type doesn't prevent RVO?
@lysdexic @QuadriLiteral Eh, no. Really. Changing the value category disables RVO
RVO
I recommend you read the thread.
@lysdexic I did.
It doesn't look like it, otherwise you'd be aware that the whole point of this submission is that casting return values with
std::movedisables RVO.@lysdexic You claimed otherwise:
"
These std::move invocations are harmless, as they only cast objects to their rvalue reference.
"
If you were right, we wouldn't have the motivation to look at this in EWG.If you were right, we wouldn’t have the motivation to look at this in EWG.
I am right. Not benefiting from RVO does not mean you're harming anyone.
Again, I recommend you read the submission and also the discussion.