Why would/wouldn’t you switch to a modern IDE like Visual Studio/VS Code if given the decision right now?
out of curiousity, since I feel like most of the time I touch any vi derivative it’s because I need a text editor on a command line, not because I really really wanna use it
You do have the option of using whatever you feel is best in any particular circumstance. There's no reason you need to commit to one of vim or vscode for absolutely everything, and being familiar with a few different tools can be helpful.
For example, if I'm working closely with a team that primarily uses vscode or a jetbrainz IDE then I tend to switch to that since it makes collaboration a little easier.
agreeing with krogoth - i use vscode via github's web editor and other such buffoonery, and since many of my teammates also use microsoft's loss-leader false-flag not-quite open-source community trojan editor, I have to stay reasonably current.
so i'm conversant, and use it, but i wouldn't "switch" in the sense of "adopt as my daily driver", for reasons which should be obvious from the last sentence ;)