I've always felt that Oneplus is a brand that I should like on principle of having clean software with barebones but powerful hardware, but in reality, every single Oneplus phone I've seen always had some sort of big BUTs attached to them, so buying Oneplus always feels like settling.
Take the Oneplus One for example, that sandstone textured cover was THE most creative material I felt a phone could have had, and I'm honestly shocked nobody has ever done it again. But along with that of course, comes with the cringy "smash your phone" marketing campaign, the half-hearted attempt to distance themselves from their parent company Oppo, the whole software mess with CyanogenMod/OxygenOS, etc.
Had a Oneplus 3T for a while, same deal: Great phone when it works as intended, but they raised their price without making the phone better, and the inexplicable random restarts/battery drain is so irritating, never had another phone that does that.
Recently they've dropped all pretense of not being Oppo and abandoned their core audience, choosing to have the "courage" to drop the headphone jack. Mediocre Chinese phones with flagship specs are a dime a dozen, I just don't see a reason to buy them anymore.
My 5T has been my daily driver for years. I've replaced the battery & USB port on it once so far, and that's it. I've also run LineageOS (rooted + Magisk) since day 1, which I agree is its own set of challenges. Seriously no complaints and I'm not really shopping for anything more right now.
If the Fairphone 5 specs are solid I may take the plunge, but for my needs nothing else out there has been compelling enough to make a change.